From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Thu, 14 Jan 2010 09:05:49 GMT
Subject: Re: [PATCH 10/18] rebase -i: Improve consistency of commit count in generated commit messages
Message-ID: <4B4EDE6D.3070306@alum.mit.edu>
In-Reply-To: <4B4ECD9E.5000707@viscovery.net>

Johannes Sixt wrote:
> Michael Haggerty schrieb:
>> Use the numeral "2" instead of the word "two" when two commits are
>> being interactively squashed.  This makes the treatment consistent
>> with that for higher numbers of commits.
> 
> Huh? This is just code churn: consistency is not an advantage here.
> 
> Oh...wait... The next patch needs it this way. Couldn't you have justified
> it with "In a subsequent change, we will extract the numeral and use it in
> an expression."

In the non-git universe, consistency in the user interface *is*
considered an advantage :-)  But I will be happy to add your suggested
*second* justification for the change in v2.

Michael