From: Johannes Sixt <j.sixt@viscovery.net>
Date: Thu, 14 Jan 2010 07:44:54 GMT
Subject: Re: [PATCH 09/18] t3404: Test the commit count in commit messages generated by "rebase -i"
Message-ID: <4B4ECB76.3030009@viscovery.net>
In-Reply-To: <c3ec064944c4c5e6a3eba5c71e8956fe8bceb3ad.1263447037.git.mhagger@alum.mit.edu>

Michael Haggerty schrieb:
> +	test -z "$EXPECT_HEADER_COUNT" ||
> +		test "$EXPECT_HEADER_COUNT" = $(sed -n '1s/^# This is a combination of \(.*\) commits\./\1/p' < "$1") ||
> +		exit

Is an empty $EXPECT_HEADER_COUNT an error? I suppose it isn't; therefore,
you must put the second 'test' and the 'exit' in a brace group.

You should also put the $(sed) in double-quotes.

-- Hannes