From: Ben Knoble Date: Fri, 27 Mar 2026 16:47:48 GMT Subject: Re: [PATCH] docs: fix git stash grammar Message-ID: <4B4B5BCF-BC0C-42A1-A6F1-52FF96EF0BFC@gmail.com> In-Reply-To: > > Le 26 mars 2026 à 20:04, Mirko Faina a écrit : > > On Thu, Mar 26, 2026 at 12:17:46PM -0400, D. Ben Knoble wrote: >> Now, _is_ the grammar bracketed wrong? "git help stash" says >> >> For quickly making a snapshot, you can omit "push". In this mode, >> non-option arguments are not allowed to prevent a misspelled >> subcommand from making an unwanted stash entry. The two exceptions >> to this are stash -p which acts as alias for stash push -p and >> pathspec elements, which are allowed after a double hyphen -- for >> disambiguation. >> >> So _if_ you want to provide options (other than "-p"), the "push" is >> required. I think the existing brackets indicate that. > > When it says "In this mode, non-option arguments are not allowed" > wouldn't -m be allowed as it is an option and not a non-option? In fact > if we do try to run "git stash -m something" it does correctly stash > while if we do something like "git stash pathspec" it does give back > "fatal: subcommand wasn't specified; 'push' can't be assumed due to > unexpected token 'pathspec'". > > If that is the case then there is an issue with the way the usage > tooltip shows the optionality of "push". Indeed, thanks.