From: Johannes Sixt Date: Tue, 15 Dec 2009 08:42:06 GMT Subject: [PATCH 1/2] filter-branch: remove an unnecessary use of 'git read-tree' Message-ID: <4B274BDE.8000504@viscovery.net> From: Johannes Sixt The intent of this particular call to 'git read-tree' was to fill an index. But in fact, it only allocated an empty index. Later in the program, the index is filled anyway by calling read-tree with specific commits, and considering that elsewhere the index is even removed (i.e., it is not relied upon that the index file exists), this first call of read-tree is completely redundant. Signed-off-by: Johannes Sixt --- Calling read-tree without arguments is not allowed according to the documentation. The next patch will enforce this. -- Hannes git-filter-branch.sh | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/git-filter-branch.sh b/git-filter-branch.sh index cb9d202..195b5ef 100755 --- a/git-filter-branch.sh +++ b/git-filter-branch.sh @@ -259,7 +259,6 @@ test -s "$tempdir"/heads || GIT_INDEX_FILE="$(pwd)/../index" export GIT_INDEX_FILE -git read-tree || die "Could not seed the index" # map old->new commit ids for rewriting parents mkdir ../map || die "Could not create map/ directory" -- 1.6.6.rc1.46.g1635