From: Ramsay Jones Date: Fri, 04 Dec 2009 22:58:13 GMT Subject: Re: [RFC PATCH 2/2] MSVC: Fix an "incompatible pointer types" compiler warning Message-ID: <4B199405.8040607@ramsay1.demon.co.uk> In-Reply-To: Johannes Schindelin wrote: > On Thu, 3 Dec 2009, Ramsay Jones wrote: > >> compat/mingw.h | 27 ++++++++++++++++++++++++++- >> compat/msvc.h | 25 +------------------------ >> 2 files changed, 27 insertions(+), 25 deletions(-) > > I'd prefer to have the MSVC-specific definitions in msvc.h, along with a > definition of, say, ALREADY_DEFINED_STATI64 or some such (which tells > mingw.h not to do anything about those types). There is no need to > clutter mingw.h with stuff for MSVC. Ah, yeah, I did think about this. As I said, the original patch was much simpler and I thought the change to mingw.h was just this side of being objectionable ;-) However, as the patch continued to gain weight I should have re-evaluated that... my bad. New version of the patch coming soon. ATB, Ramsay Jones