From: Johannes Sixt <j.sixt@viscovery.net>
Date: Fri, 27 Nov 2009 07:09:40 GMT
Subject: Re: [PATCH/RFC 02/11] strbuf: add non-variadic function strbuf_vaddf()
Message-ID: <4B0F7B34.4090908@viscovery.net>
In-Reply-To: <40aa078e0911261537r40b19dffqf019848dcad23fef@mail.gmail.com>

Erik Faye-Lund schrieb:
> Perhaps I can do one better: use memcpy instead of standard
> assignment. The Autoconf manual[1] suggests that it's more portable.
> Something like this:
> 
> #ifndef va_copy
> # ifdef __va_copy
> #  define va_copy(a,b) __va_copy(a,b)
> # else
> #  define va_copy(a,b) memcpy(&a, &b, sizeof (va_list))
> # endif
> #endif
> 
> I'll add this to git-compat-util.h this for the next round unless
> someone yells really loud at me.

As I said elsewhere in the thread, I do not see enough reason to add
strbuf_vaddf() only for a syslog() emulation in the first place.

-- Hannes