From: Johannes Sixt <j.sixt@viscovery.net>
Date: Tue, 03 Nov 2009 07:22:39 GMT
Subject: Re: [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one
Message-ID: <4AEFDA3F.2070405@viscovery.net>
In-Reply-To: <4AE745FB.1060902@ramsay1.demon.co.uk>

Ramsay Jones schrieb:
> diff --git a/Makefile b/Makefile
> index fea237b..8e1cfc5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)
>  	NO_MMAP = YesPlease
>  	NO_IPV6 = YesPlease
>  	X = .exe
> +	COMPAT_OBJS += compat/cygwin.o
> +	UNRELIABLE_FSTAT = UnfortunatelyYes
>  endif
>  ifeq ($(uname_S),FreeBSD)
>  	NEEDS_LIBICONV = YesPlease
> @@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)
>  	NO_SYS_SELECT_H = YesPlease
>  	SNPRINTF_RETURNS_BOGUS = YesPlease
>  endif
> -ifneq (,$(findstring CYGWIN,$(uname_S)))
> -	COMPAT_OBJS += compat/cygwin.o
> -	UNRELIABLE_FSTAT = UnfortunatelyYes
> -endif
>  ifdef MSVC
>  	GIT_VERSION := $(GIT_VERSION).MSVC
>  	pathsep = ;

I think this an obviously good change even outside this series.

-- Hannes