From: Johannes Sixt <j6t@kdbg.org>
Date: Sat, 31 Oct 2009 20:12:46 GMT
Subject: Re: [PATCH] Update packfile transfer protocol documentation
Message-ID: <4AEC9A3E.7030601@kdbg.org>
In-Reply-To: <20091031020634.GL10505@spearce.org>

Shawn O. Pearce schrieb:
> Scott Chacon <schacon@gmail.com> wrote:
>> +Currently only 'host' is allowed in the extra information.  It's
> 
> No.  We should make this a MUST.  As in:
> 
> 	Only host-parameter is allowed in the git-proto-request.
> 	Clients MUST NOT attempt to send additional parameters.
> 
> Sending another header can cause older git-daemons to lock up.

I think you are making a wrong case here: Older git-daemons that lock up 
are security holes because they allow DoS attacks, and any decent admin 
will want to upgrade to a fixed git-daemon anyway.

Fixed git-daemons can allow extra information in addition to 'host'. I 
know you argued otherwise when you submitted the fix to git-daemon, but I 
think you were wrong already back then.

-- Hannes