From: Johannes Sixt <j.sixt@viscovery.net>
Date: Fri, 16 Oct 2009 10:34:23 GMT
Subject: Re: [PATCH] grep: do not segfault when -f is used
Message-ID: <4AD84C2F.5000809@viscovery.net>
In-Reply-To: <1255683204-28988-1-git-send-email-kraai@ftbfs.org>

Matt Kraai schrieb:
> "git grep" would segfault if its -f option was used because it would
> try to use an uninitialized strbuf, so initialize the strbuf.

Thanks for noticing and for the patch.

But...

> +test_expect_success 'grep should not segfault with -f' '
> +        test_must_fail git grep -f /dev/null
> +'

there must be a better way to test whether grep -f behaves correctly.

-- Hannes