From: Johannes Sixt <j.sixt@viscovery.net>
Date: Tue, 13 Oct 2009 07:30:15 GMT
Subject: Re: [RFC PATCH v2 12/16] Smart fetch and push over HTTP: server side
Message-ID: <4AD42C87.6000205@viscovery.net>
In-Reply-To: <1255400715-10508-13-git-send-email-spearce@spearce.org>

Shawn O. Pearce schrieb:
> diff --git a/http-backend.c b/http-backend.c
> index 39cfd25..adb3256 100644
> --- a/http-backend.c
> +++ b/http-backend.c

#include "run-command.h" is missing here because you added it already in
patch 10/16 unnecessarily.

> +	if (start_command(&cld))
> +		die_errno("Cannot start %s", argv[0]);
> ...
> +	if (finish_command(&cld))
> +		die("%s terminated with error", argv[0]);

start_command and finish_command already write an error message for you
that includes argv[0] and errno. You can just exit(1) here.

-- Hannes