From: Jens Lehmann Date: Tue, 06 Oct 2009 11:51:09 GMT Subject: Re: [PATCH] Add the --submodule-summary option to the diff option family Message-ID: <4ACB2F2D.8010503@web.de> In-Reply-To: Johannes Schindelin schrieb: > Hi, > > On Tue, 6 Oct 2009, Junio C Hamano wrote: > >> Jens Lehmann writes: >> >>>> But I really, really, really want to avoid a fork() in the common case. I >>>> do have some users on Windows, and I do have a few submodules in that >>>> project. Having too many fork() calls there would just give Git a bad >>>> reputation. And it has enough of that, it does not need more. >>> Me too thinks performance matters here. We do have a repo at my dayjob >>> with more than a handful of submodules and its main target platform is >>> windows ... so having that perform nicely is a win for us. >> Numbers? >> >> I'd prefer to avoid kludges that favors unsubstantiated performance >> argument over correctness. > > Well, having worked with msysGit for such a long time, I just _know_ that > a subprocess costs a substantial amount of time. > > But as you don't trust my words, maybe Jens could be so kind as to perform > some benchmarks? I am short on Git time budget, but I will make a commit > on my submodule-summary branch that allows to start a subprocess always. Sure, will do. Jens