From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Sat, 26 Sep 2009 19:28:42 GMT
Subject: Re: [PATCH] Remove various dead assignments and dead increments found by the clang static analyzer
Message-ID: <4ABE6B6A.4000400@lsrfire.ath.cx>
In-Reply-To: <87ske9cya9.fsf@master.homenet>

> diff --git a/diff.c b/diff.c
> index e1be189..e75f58e 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -901,7 +901,7 @@ static void show_stats(struct diffstat_t *data, struct diff_options *options)
>  
>  	/* Find the longest filename and max number of changes */
>  	reset = diff_get_color_opt(options, DIFF_RESET);
> -	set   = diff_get_color_opt(options, DIFF_PLAIN);
> +	diff_get_color_opt(options, DIFF_PLAIN);
>  	add_c = diff_get_color_opt(options, DIFF_FILE_NEW);
>  	del_c = diff_get_color_opt(options, DIFF_FILE_OLD);

diff_get_color_opt() has no side-effects; the changed line is a no-op.

René