From: Johannes Sixt <j.sixt@viscovery.net>
Date: Wed, 16 Sep 2009 16:14:57 GMT
Subject: Re: [PATCH 04/15] Set _O_BINARY as default fmode for both MinGW and MSVC
Message-ID: <4AB10F01.9010703@viscovery.net>
In-Reply-To: <929c5a34cd2621af24bcda7e47ff2e76b51c2e09.1253088099.git.mstormo@gmail.com>


Marius Storm-Olsen schrieb:
> From: Marius Storm-Olsen <marius.storm-olsen@nokia.com>
> 
> MinGW set the _CRT_fmode to set both the default fmode and
> _O_BINARY on stdin/stdout/stderr. Rather use the main()
> define in mingw.h to set this for both MinGW and MSVC.
> 
> This will ensure that a MinGW and MSVC build will handle
> input and output identically.

This one breaks t5302-pack-index.sh (test 15, "[index v1] 2) create a
stealth corruption in a delta base reference") in my MinGW build. I have
yet to find out what exactly goes wrong and how it could be fixed.

-- Hannes