From: Marius Storm-Olsen <marius@storm-olsen.com>
Date: Mon, 14 Sep 2009 19:42:32 GMT
Subject: Re: [PATCH 08/17] Test for WIN32 instead of __MINGW32_
Message-ID: <4AAE9CA8.1070900@gmail.com>
In-Reply-To: <7v1vm9cohd.fsf@alter.siamese.dyndns.org>

Junio C Hamano said the following on 14.09.2009 21:31:
> Marius Storm-Olsen <mstormo@gmail.com> writes:
> 
>> From: Frank Li <lznuaa@gmail.com>
>>
>> The code which is conditional on MinGW32 is actually conditional on Windows.
>> Use the WIN32 symbol, which is defined by the MINGW32 and MSVC environments,
>> but not by Cygwin.
>>
>> Signed-off-by: Frank Li <lznuaa@gmail.com>
>> Signed-off-by: Marius Storm-Olsen <mstormo@gmail.com>
> 
> The description sounds very sensible; I wish I read this one first, before
> wasting time scratching my head while reading 03/17.  Shouldn't that patch
> be squashed into this one?

Heh, yeah, I agree. After patch got updated with suggestions from last 
roll, it clearly makes more sense hear now. I'll update tomorrow. Thanks.

--
.marius