From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 14 Sep 2009 13:37:40 GMT
Subject: Re: [PATCH 2/2] remove NORETURN from function pointers
Message-ID: <4AAE4724.1090705@viscovery.net>
In-Reply-To: <40aa078e0909140626k63b9de2fu8c9411baf8200da6@mail.gmail.com>

Erik Faye-Lund schrieb:
> On Mon, Sep 14, 2009 at 3:19 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> "The" warning? Not "the two" warnings? Then I suggest to stop here; MSVC
>> is only half-competent with regards to noreturn.
> 
> There was only one warning in this regard on MSVC - the one about
> unreachable code. And yes, MSVC is only half-competent, but it seems
> it's competence is in the half that matters in our case.
> 
> Do you suggest to stop the patch-series, or to stop the testing?

My suggestion was about stopping the patch series.

But thinking a bit more about it, I can imagine that there are calls to
die() that, if it is not marked noreturn, could trigger other warnings
with MSVC. That would be annoying, and it's better to mark it noreturn.

So I withdraw my suggestion to stop :-)

-- Hannes