From: Marius Storm-Olsen <mstormo@gmail.com>
Date: Fri, 21 Aug 2009 13:46:35 GMT
Subject: Re: [PATCH 01/14] Fix non-constant array creation
Message-ID: <4A8EA53B.9080809@gmail.com>
In-Reply-To: <40aa078e0908210641m660b003do6f637535293672ae@mail.gmail.com>

Erik Faye-Lund said the following on 21.08.2009 15:41:
> On Fri, Aug 21, 2009 at 3:30 PM, Marius Storm-Olsen<mstormo@gmail.com> wrote:
>> @@ -1875,7 +1875,7 @@ static int match_fragment(struct image *img,
>>                size_t imgoff = 0;
>>                size_t preoff = 0;
>>                size_t postlen = postimage->len;
>> -               size_t imglen[preimage->nr];
>> +               size_t *imglen = xmalloc(sizeof(size_t) * preimage->nr);
> 
> How about using alloca instead? It allocates from the stack (just like
> the C99-style variable-length array you're replacing), and you don't
> need to free the memory afterwards.
> 
> ... or is alloca frowned upon? I see it's already used both in
> compat/regex/regex.c and in compat/nedmalloc/malloc.c, but not
> apparently not in the git core.

MSVC compiles regex.c, so it must handle it. I'm fine with that.

--
.marius