From: Johannes Sixt Date: Mon, 17 Aug 2009 07:52:18 GMT Subject: Re: [msysGit] quick question about __stdcall at run-command.c mingw.c Message-ID: <4A890C32.6010507@viscovery.net> In-Reply-To: Pat Thoyts schrieb: > 2009/8/17 Frank Li : >> I am tring to clear VC build patch. >> >> I found __stdcall position break MSVC build. >> >> static __stdcall unsigned run_thread(void *data) >> >> MSVC require __stdcall should be between return type and function name. >> like >> static unsigned __stdcall run_thread(void *data) >> >> I think msys gcc should support MSVC format. >> >> Should I directly change to MSVC format or add _MSC_VER marcro like >> >> #if defined(__MINGW32__) >> static __stdcall unsigned run_thread(void *data) >> #elif defined(_MSC_VER) /*MSVC must put __stdcall between return value >> and function*/ >> static unsigned __stdcall run_thread(void *data) >> #endif > > The win32 api prototype used for thread entry functions is declared as > a DWORD (WINAPI *LPTHREAD_START_ROUTINE)(LPVOID) type in the mingw > headers and WINAPI as #define WINAPI __stdcall. This is true for the > MSVC headers as well. So gcc and msvc are happy using the same > definition for such a function and just "static unsigned long WINAPI > run_thread(void *)" might well be sensible. Change the code to static unsigned __stdcall run_thread(void *data) The documentation explictly says: "The routine at start_address passed to _beginthreadex must use the __stdcall calling convention...". So __stdcall it is. -- Hannes