From: Stephen Boyd <bebarino@gmail.com>
Date: Thu, 23 Jul 2009 06:11:33 GMT
Subject: Re: [PATCH v4] grep: Add --max-depth option.
Message-ID: <4A67FF15.7080703@gmail.com>
In-Reply-To: <1248285135-9033-1-git-send-email-michal.kiedrowicz@gmail.com>

This looks good now. Just one minor point but I don't think it requires
a resend.

Michał Kiedrowicz wrote:
>
> +		{ OPTION_INTEGER, 0, "max-depth", &opt.max_depth, "depth",
> +			"descend at most <depth> levels", PARSE_OPT_NONEG,
> +			NULL, 1 },

This NULL and 1 are not needed unless you're using PARSE_OPT_OPTARG. I
think this last line can be safely removed.