From: Paolo Bonzini <bonzini@gnu.org>
Date: Mon, 20 Jul 2009 11:50:53 GMT
Subject: Re: [PATCH 2/3] push: add --current
Message-ID: <4A645A1D.8010401@gnu.org>
In-Reply-To: <be6fef0d0907200315j14089edcv8baa997d2ec34f3f@mail.gmail.com>

On 07/20/2009 12:15 PM, Tay Ray Chuan wrote:
> Hi,
>
> On Mon, Jul 20, 2009 at 2:36 PM, Paolo Bonzini<bonzini@gnu.org>  wrote:
>>   t/t5516-fetch-push.sh      |   50 ++++++++++++++++++++++++++++++++++++++++++++
>
> since you're making modifications to pushing over HTTP, you should
> consider making tests also for HTTP repositories, or else your changes
> in http-push.c won't be used.

Yeah, I had tested them with a server I already had setup rather than 
with the testsuite, because the default Apache setup of Fedora is not 
detected correctly by lib-httpd.sh.  Any test I included would then be 
untested, while http-push.c was tested. :-)

However, I'll include the tests in v3 of the patch.

Paolo