From: Paolo Bonzini <bonzini@gnu.org>
Date: Sun, 19 Jul 2009 21:46:38 GMT
Subject: Re: [PATCH 1/3] push: add --current
Message-ID: <4A63943E.80209@gnu.org>
In-Reply-To: <20090720063244.6117@nanako3.lavabit.com>

Thanks for the review!

> If your final belief (which I happen to agree) is that
> 
> % git push --current
> % git push --current origin
> % git push --current over.there.example.com:project.git
> 
> should work as expected [...] mark clearly that the code after this patch is still broken

Okay, will do.  I just wanted to present both possibilities and thought
that (succeeding) tests were the best way to illustrate the difference.
 For the final submission, now that I had a second opinion, I'll
probably just squash 1/3 and 2/3 together.

> The style of the existing tests in the script isn't
> 
> 	test `git rev-parse master` = `cd b.git && git rev-parse master`
> 
> but is
> 
> 	test "$(git rev-parse master)" = "$(cd b.git && git rev-parse master)"

Will do.

Paolo