From: Johannes Sixt Date: Thu, 16 Jul 2009 08:17:40 GMT Subject: Re: [PATCH v5] Re: git-am: allow e-mail file(s) as input Message-ID: <4A5EE224.6020702@viscovery.net> In-Reply-To: <20090716080657.GJ12971@vidovic> Nicolas Sebrecht schrieb: > The 16/07/09, Nicolas Sebrecht wrote: >> The 16/07/09, Junio C Hamano wrote: >>> This patch wastes an extra sed process >> Should we really worry about that in a script like git-am.sh? I mean, >> does it matter in a day to day work? > > Oh I've forgotten, yes we need it: sed -e '/^$/q' leaves this matching > line to the output. An extra CRLF makes 'grep -v' fail. Then make it sed -n -e '/^$/q' -e p This won't print the trailing empty line. -- Hannes