From: Ferry Huberts <ferry.huberts@pelagic.nl>
Date: Sun, 14 Jun 2009 08:49:40 GMT
Subject: Re: [JGIT PATCH 2/2] Allow core.packedGitLimit to exceed "2 g"
Message-ID: <4A34B9A4.7020702@pelagic.nl>
In-Reply-To: <20090613191943.GS16497@spearce.org>

> If you looked at that, 2,000,000,000 is within the range of an int.
> We select the smallest value.  The first argument expression is
> computed as a long, so we shouldn't ever overflow and cause the
> first argument to be negative.  If the first argument is larger
> than 2 billion, then it does risk overflow, but the 2nd argument
> is smaller, so it is returned.
> 
> The code is fine as is.
>  

I stand corrected :-)