From: H. Peter Anvin Date: Tue, 09 Jun 2009 15:25:32 GMT Subject: Re: [PATCH v3 0/3] automatically skip away from broken commits Message-ID: <4A2E7EEC.2050807@zytor.com> In-Reply-To: Christian Couder wrote: > On Tue, Jun 9, 2009 at 6:24 AM, Christian > Couder wrote: >> So I would be ok to implement a config option or a switch to "git >> bisect start" to let people use a PRNG instead of my algorithm but I >> think something like my algorithm should be the default. > > Another reason to have 2 algorithms is that when you use "git bisect > run" you might want to use the PRNG one because: > > - you don't care much if the bisection use some more steps (as long as > it does not get stuck) > - you can't do much if it get stuck > > On the other hand, when you bisect manually: > > - you probably won't like it if you are asked to test some commits > that won't give a lot of information > - if it get stuck, you can manually use "git bisect visualize" and/or > "git bisect skip " and/or some other manual commands to do > something about it > Sort-of-kind-of. I doubt most users will be able to recover from a stuck situation, and unless we have extremely high cost of testing (which is true for some applications) then expecting the user to optimizing manually is really bad user design. My main objection to the "skip in goodness space" is exactly the same as Junio's... it doesn't really buy you what it claims to sell. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.