From: H. Peter Anvin Date: Mon, 08 Jun 2009 21:10:18 GMT Subject: Re: [PATCH v3 0/3] automatically skip away from broken commits Message-ID: <4A2D7E3A.9060701@zytor.com> In-Reply-To: <7vzlcixwue.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > "H. Peter Anvin" writes: > >> The advantage of that -- and I have to admit I don't know if it will >> ever matter in practice -- is that using an actual PRNG: >> >> a) is less likely to get into pathological capture behaviors. >> b) doesn't make people think later that there is something magic to the >> arbitrary chosen numbers. > > My gut feeling agrees with you that both are likely to be true; these are > good points. > > Christian, what do you think? Note: I do believe we should keep the obvious optimization of "if there are no skip points in the plausible range, use the best point." We don't want a 39% increase in bisect time when not using skip. -hpa