From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 25 May 2009 06:47:18 GMT
Subject: Re: [PATCH v0 3/3] Build in git-rebase.sh
Message-ID: <4A1A3EF6.1050405@viscovery.net>
In-Reply-To: <fcaeb9bf0905242334q37ef9a05xa05315639af4daf3@mail.gmail.com>

Nguyen Thai Ngoc Duy schrieb:
> On Mon, May 25, 2009 at 4:16 PM, Johannes Sixt <j.sixt@viscovery.net> wrote:
>> Nguyen Thai Ngoc Duy schrieb:
>>> Someone with better Windows knowledge than me should explain how this works. Windows'
>>> snprintf() just cuts out the last character in this statement:
>>>
>>> snprintf(buf, 8, "--%s", "onto"); // result: '--ont', expected: '--onto'
>> This doesn't happen for me: neither with Windows's original snprintf nor
>> with the version from compat/. Are you using the latest msysgit
>> environment to compile, i.e. gcc 4.4? There was a change regarding
>> SNPRINTF_SIZE_CORR; perhaps that's the culprit?
> 
> It could be. I used git.git's next branch, not msys4git or mingw.git
> repositories.

OK. Assuming you are using the latest msysgit compiler, which is gcc 4.4,
then you need the SNPRINTF_SIZE_CORR related patch from 4msysgit.git.

-- Hannes