From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date: Wed, 23 Jul 2025 17:44:52 GMT
Subject: Re: [GSoC PATCH v5 2/5] repo: add the field references.format
Message-ID: <4A044F64-8C3F-41FB-B079-AE10B42539ED@gmail.com>
In-Reply-To: <7d6ad7cb-e25a-41de-9588-6a3c1b0717e8@gmail.com>


> I think the fact that git_value_fn returns 'const char*' is a
> concern as it means we cannot return an allocated string.

Yeah, I was thinking about that. It is not a problem by now, but
after the acceptance of this patchset I'll start to work in the
`path.*` fields and that would be a problem.

> It would be better to pass a 'struct strbuf' to the callback and
> write the value to that instead.

When I was working on this version I was thinking about it, but I
left the way it is to make it simpler, and refactor it when
implementing the `path.*` fields. But now I think it would be
better to change it in v6.