From: Phillip Wood <phillip.wood123@gmail.com>
Date: Wed, 19 Feb 2025 14:55:29 GMT
Subject: Re: [PATCH v2 1/5] merge-tree --stdin: flush stdout to avoid deadlock
Message-ID: <49dc31a3-bdf4-4abb-85f6-2a80dbe18cad@gmail.com>
In-Reply-To: <Z7V48_q3Uu9d0D3Q@pks.im>

Hi Patrick

On 19/02/2025 06:23, Patrick Steinhardt wrote:
> 
> I was briefly wondering whether we should rather move this into
> `real_merge()` itself, which is responsible for writing to stdout. But
> the only other callsite doesn't really care as it will exit immediately
> anyway. So this is probably fine.

I did wonder about that when I was writing the patch but decided it only 
mattered when --stdin was given.

> Overall the series looks good to me, thanks!

Thanks

Phillip