From: Stephan Beyer Date: Mon, 30 Oct 2017 13:38:35 GMT Subject: Re: [PATCH v16 Part II 2/8] bisect--helper: `bisect_write` shell function in C Message-ID: <49b9e9e6-8aeb-9a14-9309-f9274fe13e7d@gmx.net> In-Reply-To: <0102015f5e5ee22c-ea9c3a38-5d42-4dce-a54b-45c59768a70b-000000@eu-west-1.amazonses.com> Also just a minor in addition to the others: > @@ -153,9 +241,10 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) > WRITE_TERMS, > BISECT_CLEAN_STATE, > CHECK_EXPECTED_REVS, > - BISECT_RESET > + BISECT_RESET, > + BISECT_WRITE > } cmdmode = 0; > - int no_checkout = 0; > + int no_checkout = 0, res = 0; This last change is not necessary. You never use "res". Stephan