From: Stephen Boyd Date: Mon, 13 Apr 2009 23:39:52 GMT Subject: Re: [PATCH RFC3 08/13] send-email: Remove superfluous `my $editor = ...' Message-ID: <49E3CD48.1010809@gmail.com> In-Reply-To: <1239647037-15381-9-git-send-email-mfwitten@gmail.com> Michael Witten wrote: > - my $editor = $ENV{GIT_EDITOR} || Git::config(@repo, "core.editor") || $ENV{VISUAL} || $ENV{EDITOR} || "vi"; I don't want to start an editor war, but why is 'vi' here? It seems that one of the previous four should be set at all times, correct?