From: Ferry Huberts (Pelagic) <ferry.huberts@pelagic.nl>
Date: Sat, 11 Apr 2009 19:41:48 GMT
Subject: Re: [PATCH v3 2/2] Ensure consistent usage of mergetool.keepBackup in git
Message-ID: <49E0F27C.8070203@pelagic.nl>
In-Reply-To: <7vljq7dmg2.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:
> Ferry Huberts <ferry.huberts@pelagic.nl> writes:
> 
>> In several places merge.keepBackup is used i.s.o.
>> mergetool.keepBackup. This patch makes it all
>> consistent for git
> 
> A silly question.  The above makes it sound as if both merge.keepBackup
> and mergetool.keepBackup are valid, but the latter is preferred, and your
> patch makes things consistent even though without it there is nothing
> broken per-se.
> 
> Is that really is the case?
> 
> Otherwise, perhaps the title and the message should read like this:
> 
>     Fix misspelled mergetool.keepBackup
>     
>     In several places mergetool.keepBackup was misspelled as merge.keepBackup.
>     
>     Signed-off-by: Ferry Huberts <ferry.huberts@pelagic.nl>

feel free to change it :-)
imho there has been way too much discussion for such a simple patch.