From: Ferry Huberts (Pelagic) <ferry.huberts@pelagic.nl>
Date: Thu, 09 Apr 2009 17:21:29 GMT
Subject: Re: [PATCH] git-svn: always initialize with core.autocrlf=false
Message-ID: <49DE2E99.9060804@pelagic.nl>
In-Reply-To: <20090409165920.GA6311@dcvr.yhbt.net>

Eric Wong wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
>> It has been reported time and time again in relation to msysGit that
>> git-svn does not work well when core.autocrlf has any value other than
>> 'false'.  So let's make it so by default.
>>
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Acked-by: Eric Wong <normalperson@yhbt.net>
> 
>> ---
>>  git-svn.perl |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/git-svn.perl b/git-svn.perl
>> index 8be6be0..d4e8fc8 100755
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -325,6 +325,7 @@ sub do_git_init_db {
>>  		command_noisy(@init_db);
>>  		$_repository = Git->repository(Repository => ".git");
>>  	}
>> +	command_noisy('config', 'core.autocrlf', 'false');
>>  	my $set;
>>  	my $pfx = "svn-remote.$Git::SVN::default_repo_id";
>>  	foreach my $i (keys %icv) {
>> -- 
>> 1.6.2.1.613.g25746
> 
funny that this kind of seems to get through while my suggestion (and
proff by tests) to do the same for the cvs-import stuff resulted in
hefty discussions and no consensus on what to do, the result of which is
to do nothing. i guess i couldn't make myself clear enough?