From: Paolo Bonzini Date: Wed, 08 Apr 2009 07:40:12 GMT Subject: Re: [PATCH 2/3] rev-list: remove last static vars used in "show_commit" Message-ID: <49DC54DC.3060408@gnu.org> In-Reply-To: <20090407040854.4338.40055.chriscool@tuxfamily.org> > struct rev_info revs; > + struct rev_list_info info; > int reaches = 0, all = 0; > > + memset(&info, 0, sizeof(info)); > + info.revs = &revs; Would it make sense to embed the struct rev_info entirely in the new struct, without going through a pointer? Paolo