From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Mon, 16 Mar 2009 17:31:17 GMT
Subject: Re: [PATCH] grep: prefer builtin over external one when coloring results
Message-ID: <49BE8CE5.2020603@lsrfire.ath.cx>
In-Reply-To: <1237170004-27768-1-git-send-email-pclouds@gmail.com>

pclouds@gmail.com schrieb:
> As far as I know, not all grep programs support coloring, so we should
> rely on builtin grep. If you want external grep, set
> color.grep.external to empty string.
> 
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---
>  How about this?
> 
>  builtin-grep.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/builtin-grep.c b/builtin-grep.c
> index 9e7e766..89489dd 100644
> --- a/builtin-grep.c
> +++ b/builtin-grep.c
> @@ -825,6 +825,8 @@ int cmd_grep(int argc, const char **argv, const char *prefix)
>  		}
>  	}
>  
> +	if (opt.color && !opt.color_external)
> +		builtin_grep = 1;
>  	if (!opt.pattern_list)
>  		die("no pattern given.");
>  	if ((opt.regflags != REG_NEWLINE) && opt.fixed)

Makes sense, thanks!

René