From: Johannes Sixt <j.sixt@viscovery.net>
Date: Thu, 12 Mar 2009 09:59:57 GMT
Subject: Re: [PATCH 2/2] Make Git respect changes to .gitattributes during checkout.
Message-ID: <49B8DD1D.3060908@viscovery.net>
In-Reply-To: <1236850575-27973-3-git-send-email-kristian.amlie@nokia.com>

Kristian Amlie schrieb:
> We do this by popping off elements on the attribute stack, until we
> reach the level where a new .gitattributes was checked out. The next
> time someone calls git_checkattr(), it will reconstruct the
> attributes from that point.
...
> +	gitattrlen = strlen(GITATTRIBUTES_FILE);
> +	pathlen = strlen(path);
> +	if (!strncmp(path + pathlen - gitattrlen, GITATTRIBUTES_FILE, gitattrlen)) {
> +		/* Invalidate attributes if a new .gitattributes file was checked out. */

But if there was file .abc.txt that was checked out before .gitattributes
was checked out, then the new .gitattributes won't have been used for
.abc.txt, yet, right?

(Disclaimer: I didn't read the code, just your description and this comment.)

-- Hannes