From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 23 Feb 2009 08:53:15 GMT
Subject: Re: [PATCH v2 09/13] refactor duplicated ref_newer() to remote.c
Message-ID: <49A263FB.7030308@viscovery.net>
In-Reply-To: <1235374171-92523-1-git-send-email-jaysoffian@gmail.com>

Jay Soffian schrieb:
> diff --git a/remote.c b/remote.c
> index 2c010a1..d0053d5 100644
> --- a/remote.c
> +++ b/remote.c
> @@ -5,6 +5,7 @@
>  #include "diff.h"
>  #include "revision.h"
>  #include "dir.h"
> +#include "tag.h"

You are only moving code from http-push.c and builtin-send-pack.c to
remote.c, but you have to add this '#include "tag.h"' here. How high are
the chances that you can remove the #include lines from http-push.c and
builtin-send-pack.c?

-- Hannes