From: Johannes Sixt <j6t@kdbg.org>
Date: Wed, 18 Feb 2009 22:27:16 GMT
Subject: Re: [PATCH 1/2] Introduce the function strip_path_suffix()
Message-ID: <499C8B44.1020106@kdbg.org>
In-Reply-To: <alpine.DEB.1.00.0902182211550.10279@pacific.mpi-cbg.de>

Johannes Schindelin schrieb:
> On Wed, 18 Feb 2009, Johannes Sixt wrote:
>> Johannes Schindelin schrieb:
>>>  strip_path_suffix("C:\\msysgit/\\libexec\\git-core",
>>>   "libexec///git-core", &prefix)
>>>
>>> will set prefix to "C:\\msysgit" and return 0.
>> But you implemented it so that prefix is actually "C:\\msysgit/\\" 
>> (unless, of course, I'm reading the code wrong).
> 
> This is supposed to handle that case:
> 
> 	*prefix = xstrndup(path, chomp_trailing_dir_sep(path, path_len));

Ah, I missed that final call of chomp_trailing_dir_sep.

-- Hannes