From: Remi Galan Alfonso Date: Tue, 02 Jun 2015 14:32:27 GMT Subject: Re: [PATCH/RFCv3 1/2] git-rebase -i: add command "drop" to remove a commit Message-ID: <49957049.34247.1433255547565.JavaMail.zimbra@ensimag.grenoble-inp.fr> In-Reply-To: Matthieu Moy : writes > > +test_expect_success 'drop' ' > > Please, be more descriptive in the first argument of > test_expect_success. It's usually a good thing to say not only what the > test stresses but also what the expected behavior is. > > test_expect_success 'drop actually drops the lines' ' For this one I've based myself on the first argument of some other tests that tests commands for git rebase -i : > t3404-rebase-interactive.sh:240 > test_expect_success 'squash' ' > t3404-rebase-interactive.sh:679 > test_expect_success 'reword' ' Rémi