From: Ted Pavlic Date: Wed, 11 Feb 2009 16:53:32 GMT Subject: Re: [PATCH 3/3] completion: Prevents GIT_PS1_DIRTYSTATE from breaking when CWD is .git Message-ID: <4993028C.4010204@tedpavlic.com> In-Reply-To: <20090211162612.GG30949@spearce.org> >> This patch uses "git rev-parse --is-inside-work-tree" to determine >> whether a "--work-tree=.." should be added to the "git diff". > > I think it makes more sense to just drop the work tree stuff from > the prompt if we aren't inside the work tree anymore. Meaning, > we should behave as though bash.showDirtyState is false. I see. At first, it seemed like it would be useful to know if the working directory was dirty even when you're within .git. However, I guess that's problematic when your working tree is in some completely unpredictable location. It's probably a bad idea to assume that work-tree=.. So you're right... there's a logical problem with having showDirtyState turned on when within .git. It should be disabled there. So I'll check for "git rev-parse --is-inside-git-dir" and disable showDirtyState appropriately. --Ted -- Ted Pavlic Please visit my ALS association page: http://web.alsa.org/goto/tedpavlic My family appreciates your support in the fight to defeat ALS.