From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Wed, 14 Jan 2009 11:14:26 GMT
Subject: Re: [PATCH] Noted that vi is the final choice of editor in git help commit
Message-ID: <496DC912.1070908@drmicha.warpmail.net>
In-Reply-To: <20090114095512.GA29927@chistera.yi.org>

Adeodato Simó venit, vidit, dixit 14.01.2009 10:55:
> * Craig Fratrik [Tue, 13 Jan 2009 14:33:36 -0800]:
> 
>>  The editor used to edit the commit log message will be chosen from the
>>  GIT_EDITOR environment variable, the core.editor configuration variable, the
>> -VISUAL environment variable, or the EDITOR environment variable (in that
>> -order).
>> +VISUAL environment variable, the EDITOR environment variable, or finally 'vi'
>> +(in that order).
> 
> May I suggest:
> 
>    The editor used to edit the commit log message will be chosen from the
>    GIT_EDITOR environment variable, the core.editor configuration variable, the
>    VISUAL environment variable, or the EDITOR environment variable (in that
>   -order).
>   +order). If none of those are set, "vi" will be used.
> 

+order). If none of those are set, "vi" will be used unless TERM is
+unset or set to "dumb".

There is also some special parsing of the value but I don't think it
needs to be advertised. The terminal-less case, on the other hand, may
be relevant for scripters and ssh'ers.

Cheers,
Michael