From: Derrick Stolee <stolee@gmail.com>
Date: Thu, 28 Jan 2021 12:57:25 GMT
Subject: Re: [PATCH 1/6] commit_graft_pos(): take an oid instead of a bare hash
Message-ID: <493fcc80-c793-0738-3b8d-b486fd05355b@gmail.com>
In-Reply-To: <YBJV07YU1Y+siwZc@coredump.intra.peff.net>

On 1/28/2021 1:12 AM, Jeff King wrote:
> All of our callers have an object_id, and are just dereferencing the
> hash field to pass to us. Let's take the actual object_id instead. We
> still access the hash to pass to hash_pos, but it's a step in the right
> direction.
> 
> This makes the callers slightly simpler, but also gets rid of the
> untyped pointer, as well as the now-inaccurate name "sha1".
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I think this one is an obvious cleanup that we'd want whether we go
> further in the series or not.

I agree. Thanks,
-Stolee