From: Derrick Stolee <derrickstolee@github.com>
Date: Thu, 23 Feb 2023 14:08:17 GMT
Subject: Re: [PATCH 06/16] hash.h: move some oid-related declarations from cache.h
Message-ID: <49082769-81b7-8a47-ace1-59c21b4396c9@github.com>
In-Reply-To: <9f78f0f215595d55ead4d82d20e1d0c9892171ec.1677139522.git.gitgitgadget@gmail.com>

On 2/23/2023 3:05 AM, Elijah Newren via GitGitGadget wrote:
> From: Elijah Newren <newren@gmail.com>
> 
> These defines and enum are all oid-related and as such seem to make
> more sense being included in hash.h.  Further, moving them there
> allows us to remove some includes of cache.h in other files.


> diff --git a/line-log.h b/line-log.h
> index 82ae8d98a40..adff361b1bc 100644
> --- a/line-log.h
> +++ b/line-log.h
> @@ -5,6 +5,7 @@
>  
>  struct rev_info;
>  struct commit;
> +struct string_list;
>  
>  /* A range [start,end].  Lines are numbered starting at 0, and the
>   * ranges include start but exclude end. */

This hunk seems unrelated to the current patch. Perhaps misplaced?

Thanks,
-Stolee