From: Michael Haggerty Date: Sat, 28 Oct 2017 04:11:45 GMT Subject: Re: [PATCH 0/2] Avoid rewriting "packed-refs" unnecessarily Message-ID: <48b59e2b-61f8-c43a-63a7-d0fb32c9b4b7@alum.mit.edu> In-Reply-To: On 10/25/2017 10:10 PM, Eric Sunshine wrote: > On Wed, Oct 25, 2017 at 5:53 AM, Michael Haggerty wrote: >> Since commit dc39e09942 (files_ref_store: use a transaction to update >> packed refs, 2017-09-08), we've been rewriting the `packed-refs` file >> unnecessarily when deleting a loose reference that has no packed >> counterpart. Add some tests demonstrating this problem, then fix it by >> teaching `files_backend` to see whether any references being deleted >> have packed versions, and if not, skipping the packed_refs >> transaction. >> >> This is a mild regression since 2.14, which avoided rewriting the >> `packed-refs` file in these cases [...] > > Should the above information (that this fixes a regression) be > mentioned in the commit message of at least one of the patches > (probably 2/2)? Without such context, it may not be clear to someone > later reading those commit message -- someone who wasn't following > this email discussion -- that this behavior had been lost and is now > being restored. Yes, that's a good idea. I'll send a re-roll with that change. Michael