From: Johannes Sixt <j.sixt@viscovery.net>
Date: Tue, 30 Sep 2008 10:29:01 GMT
Subject: Re: [PATCH] tests: grep portability fixes
Message-ID: <48E1FF6D.1050907@viscovery.net>
In-Reply-To: <48E1FB76.1040500@op5.se>

Andreas Ericsson schrieb:
> Jeff King wrote:
>> -    if ! grep -qe "Invalid gitfile format" .err
>> +    if ! grep "Invalid gitfile format" .err
> 
> Doesn't output need to be redirected when you drop '-q'?

In standard mode, the test output is directed to /dev/null anyway, and in
verbose mode the extra output doesn't hurt at all, and is usually useful
because you know that a pattern matched.

-- Hannes