From: Johannes Sixt <j.sixt@viscovery.net>
Date: Mon, 22 Sep 2008 08:20:28 GMT
Subject: Re: [PATCH (GIT-GUI,GITK) 6/8] gitk: Port new encoding logic from git-gui.
Message-ID: <48D7554C.4020601@viscovery.net>
In-Reply-To: <200809221201.35507.angavrilov@gmail.com>

Alexander Gavrilov schrieb:
> On Monday 22 September 2008 11:25:43 Johannes Sixt wrote:
>> Alexander Gavrilov schrieb:
>>> Subject: [PATCH] gitk: Implement batch lookup and caching of encoding attrs.
>>>
>>> When the diff contains thousands of files, calling git-check-attr
>>> once per file is very slow. With this patch gitk does attribute
>>> lookup in batches of 30 files while reading the diff file list,
>>> which leads to a very noticeable speedup.
>> This one does not work for me: The correct is not picked up anymore,
>> neither in Patch mode nor Tree mode. (It works as expected without this
>> patch.)
>>
> 
> OOPS, I forgot to copy the line that removes leading whitespace:

Thanks, with this it works now. The delay for a 1000 file patch is
bearable (on Windows, but y'know, Windows types are masochists :-).

Feel free to add:

Tested-by: Johannes Sixt <johannes.sixt@telecom.at>

to the patches in the series when you resend it - and I hope you do resend
it after addressing Paul's concerns.

-- Hannes