From: René Scharfe <rene.scharfe@lsrfire.ath.cx>
Date: Thu, 18 Sep 2008 20:41:00 GMT
Subject: Re: [PATCH 1/1] Make git archive respect core.autocrlf when creating zip format archives
Message-ID: <48D2BCDC.6060809@lsrfire.ath.cx>
In-Reply-To: <20080918200120.GB8631@hashpling.org>

Charles Bailey schrieb:
> There is currently no call to git_config at the start of cmd_archive.
> When creating tar archives the core config is read as a side-effect of
> reading the tar specific config, but this doesn't happen for zip
> archives.
> 
> The consequence is that in a configuration with core.autocrlf set,
> although files in a tar archive are created with crlf line endings,
> files in a zip archive retain unix line endings.

The patches look good, but it took me a while to realize that there are
two of them (0/1 and 1/1). :)

Thanks,
René