From: Andreas Ericsson <ae@op5.se>
Date: Thu, 18 Sep 2008 06:41:16 GMT
Subject: Re: [PATCH 2/4] diff.c: associate a flag with each pattern and use it for compiling regex
Message-ID: <48D1F80C.5030502@op5.se>
In-Reply-To: <7vod2m1464.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:
> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
>> This is in preparation for allowing extended regular expression patterns.
>> ...
>> @@ -100,10 +100,11 @@ static int parse_lldiff_command(const char *var, const char *ep, const char *val
>>  static struct funcname_pattern {
>>  	char *name;
>>  	char *pattern;
>> +	int cflags;
> 
> What does "C" stand for?


"compile". It's the same name as regcomp(3) uses for the flags being
used to compile the regular expression. The full mnemonic name would
be regex_compile_flag, which is a bit unwieldy. Perhaps regcomp_flags
would be a good compromise?

-- 
Andreas Ericsson                   andreas.ericsson@op5.se
OP5 AB                             www.op5.se
Tel: +46 8-230225                  Fax: +46 8-230231