From: Tom G. Christensen <tgc@statsbiblioteket.dk>
Date: Mon, 01 Sep 2008 11:03:06 GMT
Subject: Re: [PATCH] Git.pm: Use File::Temp->tempfile instead of ->new
Message-ID: <48BBCBEA.8000301@statsbiblioteket.dk>
In-Reply-To: <20080901104222.GA10026@toroid.org>

Abhijit Menon-Sen wrote:
> Perl 5.8.0 ships with File::Temp 0.13, which does not have the new()
> interface introduced in 0.14, as pointed out by Tom G. Christensen.
> 
> Signed-off-by: Abhijit Menon-Sen <ams@toroid.org>
> ---
> 
> At 2008-09-01 12:21:02 +0200, tgc@statsbiblioteket.dk wrote:
>> Wouldn't it be possible to accomplish the same as File::Temp->New with
>> the old File::Temp?
> 
> OK, does this one work for you?
> 
Nope.
I applied it to 1.6.0.1 and now get this error instead:

Parentheses missing around "my" list at 
/builddir/build/BUILD/git-1.6.0.1/t/../git-svn line 4387.
Attempt to release temp file '' that has not been locked at 
/builddir/build/BUILD/git-1.6.0.1/t/../git-svn line 3294
Can't call method "opened" on an undefined value at 
/builddir/build/BUILD/git-1.6.0.1/t/../perl/blib/lib/Git.pm line 1001.

-tgc