From: Marcus Griep <marcus@griep.us>
Date: Thu, 14 Aug 2008 23:52:01 GMT
Subject: Re: [PATCH v2 3/3] count-objects: add human-readable size option
Message-ID: <48A4C521.6090507@griep.us>
In-Reply-To: <20080814223740.GD10544@machine.or.cz>

Petr Baudis wrote:
>> +-H::
> 
> Can you guess what would I bug you about? ;-)

If we get '-h', I'll submit another patch :-P

> If it's non-human-readable anyway, why are you dividing this by 1024? At
> any rate, it is not obvious at all that the size-pack is not actually
> size-pack but size-pack/1024. You should either add the (fixed) unit
> string behind or name it size-pack-kb - or just not divide it at all?

I divide by 1024 here because the loose object size is reported in KiB.
The total that ends up in size_pack is in B, hence to be consistent, I
report the pack size in KiB as well.

-- 
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´