From: Marcus Griep <marcus@griep.us>
Date: Wed, 13 Aug 2008 03:42:50 GMT
Subject: Re: [PATCH 3/3] git-svn: Reduce temp file usage when dealing with non-links
Message-ID: <48A2583A.1000509@griep.us>
In-Reply-To: <20080813032956.GC5904@untitled>

Eric Wong wrote:
> Thank you Marcus!
> 
> Acked-by: Eric Wong <normalperson@yhbt.net>

Errr, you want to Ack [PATCH v2 3/3]; not this one; there's one minor
typo when I shortened the variable $result to $res.

>> +				my $res;
>> +				while ($res = sysread($fh, my $str, 1024)) {
>> +					my $out = syswrite($tmp_fh, $str, $res);
>> +					defined($out) && $out == $res
>> +						or croak("write ",
>> +							$tmp_fh->filename,
>> +							": $!\n");
>> +				}
>> +				defined $result or croak $!;

That last line causes compilation errors with 'use strict'.  It is fixed
in the alternate version.

-- 
Marcus Griep
GPG Key ID: 0x5E968152
——
http://www.boohaunt.net
את.ψο´