From: Olivier Marin <dkr+ml.git@free.fr>
Date: Fri, 25 Jul 2008 15:20:26 GMT
Subject: Re: [PATCH 6/9] builtin-init-db.c: use parse_options()
Message-ID: <4889EF3A.6040605@free.fr>
In-Reply-To: <alpine.DEB.1.00.0807241801030.8986@racer>

Johannes Schindelin a écrit :
>>
>>> +		OPT_BOOLEAN(0, "bare", &bare, "set up a bare repo"),
>> s/set up/setup/
> 
> No.  "setup" is a noun.

Right, sorry.

> We rely on shared_repository == 0 for non-shared repositories _almost 
> everywhere_.

I think we rely on the fact that PERM_UMASK == 0 and not on the value
of shared_repository. Not the same thing.

That said, perhaps you are right: it is harmless.

>>> +		OPT_BIT('q', "quiet", &flags, "be quiet", INIT_DB_QUIET),
>> OPT__QUIET(&quiet),
>>
>> if (quiet)
>> 	flags |= INIT_DB_QUIET;
>>
>> to use the same quiet option everywhere?
> 
> Why?  Doesn't make it more readable, I think.  I'd rather have 3 lines 
> less.

Hum.

Olivier.